feat: Voice guide rewrite - #556
Open
DA-344 wants to merge 5 commits into
Open
Conversation
Member
|
Please link issue |
Paillat-dev
self-requested a review
August 30, 2026 17:19
Deploying pycord-guide with
|
| Latest commit: |
79036de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8113213f.guide-49b.pages.dev |
| Branch Preview URL: | https://voice-guide-rewrite.guide-49b.pages.dev |
Member
|
@DA-344 You should probably add the pages & rename their sidebar entries in zensical.toml |
vmphase
suggested changes
Aug 31, 2026
| - [`Pycord.Wavelink`](https://github.com/Pycord-Development/Pycord.Wavelink), | ||
| - [`SonoLink`](https://github.com/sonolink/sonolink) - used for advanced audio playback | ||
| [`Lavalink.py`](https://github.com/Devoxin/Lavalink.py), | ||
| [`Wavelink`](https://github.com/PythonistaGuild/Wavelink) or any other Python LavaLink library for music playback. |
Member
There was a problem hiding this comment.
Wavelink does not yet provide an explicit support for pycord, redundant.
| track = result.result | ||
|
|
||
| # And finally... we play the track we obtained | ||
| await vc.play(song) |
Member
There was a problem hiding this comment.
Suggested change
| await vc.play(song) | |
| await vc.play(track) |
Comment on lines
+212
to
+215
| @bot.event | ||
| async def on_sonolink_node_ready(payload: sonolink.gateway.ReadyEvent) -> None: | ||
| print(f"Node with ID {payload.node.id!r} has connected!") | ||
| print(f"Resumed session: {payload.resumed}") |
Member
There was a problem hiding this comment.
I would insist on following sonolink guides' convention.
Suggested change
| @bot.event | |
| async def on_sonolink_node_ready(payload: sonolink.gateway.ReadyEvent) -> None: | |
| print(f"Node with ID {payload.node.id!r} has connected!") | |
| print(f"Resumed session: {payload.resumed}") | |
| @bot.event | |
| async def on_sonolink_node_ready(event: sonolink.gateway.ReadyEvent) -> None: | |
| print(f"Node with ID {event.node.id!r} has connected!") | |
| print(f"Resumed session: {event.resumed}") |
Comment on lines
+118
to
+120
| @bot.listen() | ||
| async def on_connect() -> None: | ||
| await sl_client.start() # starts connection to the created nodes |
Member
There was a problem hiding this comment.
Suggested change
| @bot.listen() | |
| async def on_connect() -> None: | |
| await sl_client.start() # starts connection to the created nodes | |
| @bot.listen() | |
| async def on_connect() -> None: | |
| await sl_client.start() # starts connection to the created nodes | |
| print("SonoLink nodes connected successfully!") |
Comment on lines
+208
to
+211
| @bot.listen() | ||
| async def on_connect() -> None: | ||
| await sl_client.start() # Starting the client & connect all nodes | ||
|
|
Member
There was a problem hiding this comment.
Duplicate of lines 118-120.
Suggested change
| @bot.listen() | |
| async def on_connect() -> None: | |
| await sl_client.start() # Starting the client & connect all nodes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Voice guides by splitting them in two:
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.